Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleaning up unbiased kernels #64

Merged
merged 8 commits into from
Apr 25, 2022
Merged

Cleaning up unbiased kernels #64

merged 8 commits into from
Apr 25, 2022

Conversation

jorgensd
Copy link
Member

@jorgensd jorgensd commented Apr 22, 2022 •
edited
Loading

  • Removing temporary allocated variables of offsets that we can precompute.
  • Add various documentation
  • Add some error handling if encountering dof permutations (as it is unsupported in our kernels).
  • Use custom pull_back_nonaffine to avoid dynamic memory allocation.
  • Move pack_ny to cpp-file as it is not templated.

@jorgensd jorgensd requested a review from SarahRo April 22, 2022 10:45
SarahRo
SarahRo reviewed Apr 22, 2022
View reviewed changes
cpp/Contact.h Outdated Show resolved Hide resolved
SarahRo
SarahRo reviewed Apr 22, 2022
View reviewed changes
cpp/Contact.h Outdated Show resolved Hide resolved
jorgensd and others added 2 commits April 23, 2022 17:33
@jorgensd
Apply suggestions from code review
d043094
@jorgensd
Move pack_ny to cpp file.
8be9589 
Add function for non-affine pullback as the cmap one has dynamic memory allocation
@jorgensd jorgensd merged commit 08e0690 into Wells-Group:main Apr 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SarahRo SarahRo SarahRo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jorgensd @SarahRo