Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add github CI actions #347

Closed

Conversation

sergiy-petrov
Copy link

@sergiy-petrov sergiy-petrov commented Dec 15, 2022

I've added integration with Github CI

I noticed that there is only one default unit test, but I hope this PR encourage you to start writing more tests within your project :)

Webklex added a commit that referenced this pull request Jan 2, 2023
@Webklex
Copy link
Owner

Webklex commented Jan 2, 2023

Hi @sergiy-petrov ,
thanks a lot for your pull request. Unfortunately I wasn't able to merge your pull request. However I would like to acknowledge your work and your suggestions which indeed influenced my changes. Please feel free to simply push a " " or "." - I'll happily merge it so you'll get listed as a contributor.

Best regards and a happy new year,

@Webklex Webklex closed this Jan 18, 2023
@sergiy-petrov sergiy-petrov deleted the github-ci-actions branch October 7, 2023 12:52
@williamdes
Copy link

The README should probably be updated since the PHP version constraints changed ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants