Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for extension recognition #325

Merged
merged 2 commits into from
Nov 14, 2022
Merged

Fix for extension recognition #325

merged 2 commits into from
Nov 14, 2022

Conversation

pwoszczyk
Copy link
Contributor

@pwoszczyk pwoszczyk commented Nov 13, 2022

Related to #323:

  • Fix for symfony/http-foundation >= 5.0.0 & not installed symfony/mime
  • Use of \Symfony\Component\Mime\MimeTypes as default guesser if possible
  • Suggestion to use symfony/mime

@pwoszczyk
Copy link
Contributor Author

pwoszczyk commented Nov 13, 2022

I think a better way to solve the problem could be to update minimum supported PHP version to 7.1 and substitute symfony/http-foundation with symfony/mime, but I don't want to break backward compatibility.

@Webklex
Copy link
Owner

Webklex commented Nov 14, 2022

Hi @pwoszczyk ,
many thanks for your pull request. We are actually planing to switch to php v8.1 with the next major release (v5.0.0). It's getting tough to support both php7 and php8 at the same time.

Thanks again :)

@Webklex Webklex merged commit d059b67 into Webklex:master Nov 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants