Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change boundary regex #152

Closed
wants to merge 1 commit into from
Closed

Change boundary regex #152

wants to merge 1 commit into from

Conversation

EthraZa
Copy link

@EthraZa EthraZa commented Aug 16, 2021

Resolves #150 where there is other header params in the same line of boundary,
as in
Content-Type: multipart/mixed; boundary="--AaZz"; filename="untitled.txt"
instead of
boundary="_34f19e771ef672441eab76cca3808103"

Resolves Webklex#150 where there is other header params in the same line of boundary
@Webklex
Copy link
Owner

Webklex commented Nov 4, 2021

Hi @EthraZa ,
your suggested regex is part of 4731293. I would feel bad to just close this pr - I would like to recognize your work (besides the profile reference). Please feel free to push a dot or what ever - I happily merge it :)

I'm sorry for screwing this up - I should have just merged it and edit it afterwards..

Best regards,

@EthraZa
Copy link
Author

EthraZa commented Nov 4, 2021

Don´t worry. I have new issues to open already. :P

@Webklex
Copy link
Owner

Webklex commented Nov 4, 2021

Thanks. I'm looking forward to them :D

@Webklex Webklex closed this Nov 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't fetch some attachments
2 participants