Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update print to python 3 and schema to https #5

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

GeorgeK-zn
Copy link

No description provided.

Copy link

@idanmel idanmel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the pull request.
We allow http requests to our API.

Can you please change the schema back to http?

@GeorgeK-zn
Copy link
Author

No worries.
To be clear the only reason for this pull request is http schema.
If you like I can change it so the user would have the option to choose http/s but truly I think that this is a bad idea.
One might use this library for the first time without checking exactly what the code does and use it to search for some very sensitive information over say cyber API.
What do you think?

@idanmel
Copy link

idanmel commented Oct 4, 2020

Hi Nescobar,
That's a good idea.
Maybe have HTTPS as the default, and give the user the option of using HTTP?

@GeorgeK-zn
Copy link
Author

@idanmel I've thought about it and I think that there is no point in leaving the HTTP schema.
With the provided services your customers may search for very sensitive data, and some of them are probably doing it right now over the clear web.
I think it should be the other way around: you should help your users by enforcing them to use a more secure connection and if someone wants they'll be able to downgrade to HTTP after changing one line of code.

@GeorgeK-zn GeorgeK-zn mentioned this pull request May 2, 2021
@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 7, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants