-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update github workloads #478
base: main
Are you sure you want to change the base?
Conversation
camillobruni
commented
Jan 29, 2025
•
edited by julienw
Loading
edited by julienw
- Use latest action versions
- Bump node version to current stable v22
- Use caches for node modules to slightly speed up setup
- Mild formatting was applied
✅ Deploy Preview for webkit-speedometer ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks okay to me.
Simplified the test.yml file based on the feedback. |
Another way would be to use a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, looks good to me!
@@ -3,7 +3,7 @@ | |||
"version": "3.0.0-alpha", | |||
"description": "An open source repository for the Speedometer benchmark.", | |||
"engines": { | |||
"node": ">=18.13.0", | |||
"node": ">=22.0.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we want to ensure that we stay on v22 by adding < 23
as well? I'm a bit afraid that this will switch to v24 automatically and we'll get build errors. We can always change that later if this happens of course.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe you need to run npm i
to update package-lock.json
as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah yeah... of course.
Let me add a CI check for that as well in a separate PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think npm ci
does it for dependencies, it's disappointing it doesn't work for everything that can update it!
cache: "npm" | ||
|
||
- name: Install Node Packages | ||
run: npm ci |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
much better!