Updated json response messages on invalid add term #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously there was a block doing multiple checks to ensure it was ok to add a new term. If it failed a very generic json error response was returned. This did not allow the user/other devs to understand why a term was not being added. This commit breaks the checks apart into their own conditionals and provides the user with better feedback when something has gone amiss.
jtsternberg
added a commit
that referenced
this pull request
Dec 7, 2015
Updated json response messages on invalid add term
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously there was a block doing multiple checks to ensure it was ok to add
a new term. If it failed a very generic json error response was returned. This
did not allow the user/other devs to understand why a term was not being added.
This commit breaks the checks apart into their own conditionals and provides the
user with better feedback when something has gone amiss.