Avoid depending on max_align_t in <__struct_sockaddr.h>.
#335
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`max_align_t` is not declared in C99 mode, so use an aligned attribute and `__BIGGEST_ALIGNMENT__` instead. Fixes WebAssembly/wasi-sdk#111.
sbc100
approved these changes
Oct 10, 2022
yamt
added a commit
to yamt/wasi-libc
that referenced
this pull request
Dec 27, 2022
Also, remove no longer necessary __need_STDDEF_H_misc stuff. References: WebAssembly#335 WebAssembly/wasi-sdk#111 https://github.com/llvm/llvm-project/blob/2e999b7dd1934a44d38c3a753460f1e5a217e9a5/clang/lib/Headers/stddef.h#L106-L113
yamt
added a commit
to yamt/wasi-libc
that referenced
this pull request
Dec 27, 2022
Also, remove no longer necessary __need_STDDEF_H_misc stuff. References: WebAssembly#335 WebAssembly/wasi-sdk#111 https://github.com/llvm/llvm-project/blob/2e999b7dd1934a44d38c3a753460f1e5a217e9a5/clang/lib/Headers/stddef.h#L106-L113
sunfishcode
pushed a commit
that referenced
this pull request
Jan 9, 2023
Also, remove no longer necessary __need_STDDEF_H_misc stuff. References: #335 WebAssembly/wasi-sdk#111 https://github.com/llvm/llvm-project/blob/2e999b7dd1934a44d38c3a753460f1e5a217e9a5/clang/lib/Headers/stddef.h#L106-L113
john-sharratt
pushed a commit
to john-sharratt/wasix-libc
that referenced
this pull request
Mar 6, 2023
Also, remove no longer necessary __need_STDDEF_H_misc stuff. References: WebAssembly#335 WebAssembly/wasi-sdk#111 https://github.com/llvm/llvm-project/blob/2e999b7dd1934a44d38c3a753460f1e5a217e9a5/clang/lib/Headers/stddef.h#L106-L113
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
max_align_tis not declared in C99 mode, so use an aligned attribute and__BIGGEST_ALIGNMENT__instead.Fixes WebAssembly/wasi-sdk#111.