Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The cursor in list-keys should probably be a string, not a u64 #45

Open
manuel opened this issue Jul 13, 2024 · 1 comment · May be fixed by #46
Open

The cursor in list-keys should probably be a string, not a u64 #45

manuel opened this issue Jul 13, 2024 · 1 comment · May be fixed by #46

Comments

@manuel
Copy link

manuel commented Jul 13, 2024

E.g. in Cloudflare KV https://developers.cloudflare.com/kv/api/list-keys/:

cursor is a string used for paginating responses.
@thomastaylor312
Copy link
Collaborator

Yeah I was just looking at some stuff for compare and swap and realized we should probably change this. I'll make this update when I come back with some updates for CAS operations!

thomastaylor312 added a commit to thomastaylor312/wasi-keyvalue that referenced this issue Jul 29, 2024
@thomastaylor312
feat(*)!: Adds cas operation and fixes keys cursor
e24291a 
This PR incorporates some feedback received on the current draft interface.
First off, this changes the cursor for listing keys to be a string instead
of a number in order to support more systems.

The second changes adds back in a CAS operation as multiple people had
been asking for it. See the discussion in WebAssembly#44 for more context.

Because these are breaking changes and there are multiple draft
implementations out there, I bumped this to draft2. Ideally we should be
able to move to an RC soon with these changes added in

Closes WebAssembly#44
Closes WebAssembly#45

Signed-off-by: Taylor Thomas <taylor@cosmonic.com>
@thomastaylor312 thomastaylor312 linked a pull request Jul 29, 2024 that will close this issue
Open
thomastaylor312 added a commit to thomastaylor312/wasi-keyvalue that referenced this issue Aug 9, 2024
@thomastaylor312
feat(*)!: Adds cas operation and fixes keys cursor
9915d37 
This PR incorporates some feedback received on the current draft interface.
First off, this changes the cursor for listing keys to be a string instead
of a number in order to support more systems.

The second changes adds back in a CAS operation as multiple people had
been asking for it. See the discussion in WebAssembly#44 for more context.

Because these are breaking changes and there are multiple draft
implementations out there, I bumped this to draft2. Ideally we should be
able to move to an RC soon with these changes added in

Closes WebAssembly#44
Closes WebAssembly#45

Signed-off-by: Taylor Thomas <taylor@cosmonic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(*)!: Adds cas operation and fixes keys cursor thomastaylor312/wasi-keyvalue
2 participants
@manuel @thomastaylor312