Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add options to wat-writer #436

Closed
5 of 6 tasks
binji opened this issue May 15, 2017 · 4 comments
Closed
5 of 6 tasks

Add options to wat-writer #436

binji opened this issue May 15, 2017 · 4 comments

Comments

@binji
Copy link
Member

binji commented May 15, 2017

@kanaka mentions here that having some of the sugar makes for easier debugging. It shouldn't be too much work to add options to the wat-writer to support this:

  • inline function types for imported functions (not valid in text format)
  • inline imports
  • inline exports
  • mnemonic labeling of variables (you can do this currently with the --generate-names flag, perhaps should be done by default?)
  • optional expression folding
  • use import/export name as debug name if no other debug name is supplied
@kanaka
Copy link

kanaka commented May 15, 2017

@binji yes, function types is what I was referring to.

@binji
Copy link
Member Author

binji commented May 16, 2017

OK, thanks. wasm2wast already displays the inline function type for defined functions, but doesn't display them for imported functions.

@binji
Copy link
Member Author

binji commented May 26, 2017

I realized it's not too hard to do expression folding, and fall back to stacky format when it's not possible: #460

@binji
Copy link
Member Author

binji commented Jan 9, 2018

Added last feature (inline imports) here. Closing.

@binji binji closed this as completed Jan 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants