[spec/interpreter/test] Rename memory instructions #649
Conversation
|
Can discuss and vote on this in the next CG meeting before doing the change? I don't think it's purely editorial given that some tooling already relies on it. |
|
@jfbastien, absolutely. Didn't plan to land this before that. |
document/js-api/index.bs
Outdated
| text: 𝗂𝟥𝟤.𝖼𝗈𝗇𝗌𝗍 | ||
| text: 𝖿𝟥𝟤.𝖼𝗈𝗇𝗌𝗍 | ||
| text: 𝖿𝟨𝟦.𝖼𝗈𝗇𝗌𝗍 | ||
| text: 헂ퟨퟦ.햼허헇헌헍 |
There was a problem hiding this comment.
Wow, no idea. I think my editor barfed on the extended Unicode. Fixed, but @littledan, why this fancy? I for one have no idea how I would even input these characters if I needed to edit any of this.
interpreter/host/spectest.ml
Outdated
| @@ -38,5 +38,5 @@ let lookup name t = | |||
| | "global", ExternGlobalType t -> ExternGlobal (global t) | |||
| | "global", _ -> ExternGlobal (global (GlobalType (I32Type, Immutable))) | |||
| | "table", _ -> ExternTable table | |||
| | "memory", _ -> ExternMemory memory | |||
| | "memory", _ -> ExternMem mem | |||
|
This only affects text encoding correct? All binary encoding and opcodes remain the same, yes? |
|
@ballercat, yes. |
|
This came up at the Feb 21st CG meeting. There wasn't much discussion, other than some mentioning they didn't like I see now that all we really needed was a CG vote for this, but that didn't happen unfortunately. Perhaps the best thing to do for now is update this PR and wait for the next one to get an official vote? |
|
Alternative PR with long names: #720. |
|
Abandoned in favour of #720 after CG decision. |
This is a PR to implement #627. It renames:
current_memory->mem.sizegrow_memory->mem.growmemory->mem(in memory declarations, imports, and exports)It also adjusts the naming conventions in the interpreter and adapts all tests.