Update JavaScript WasmModuleBuilder with new functionality. #530
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
backes
reviewed
Jul 26, 2017
test/harness/wasm-module-builder.js
Outdated
| @@ -100,17 +107,23 @@ class WasmFunctionBuilder { | |||
|
|
|||
| addBody(body) { | |||
| for (let b of body) { | |||
| if (typeof b !== 'number' || (b & (~0xFF)) !== 0 ) | |||
There was a problem hiding this comment.
It seems that in this case, the version in the spec repo was updated to do even stricter tests. Hence we should merge this change back to v8.
There was a problem hiding this comment.
Good catch. I had just blindly copied over the v8 version instead of merging the two.
test/harness/wasm-module-builder.js
Outdated
| @@ -365,10 +378,9 @@ class WasmModuleBuilder { | |||
| if (debug) print("emitting memory @ " + binary.length); | |||
| binary.emit_section(kMemorySectionCode, section => { | |||
| section.emit_u8(1); // one memory entry | |||
| const has_max = wasm.memory.max !== undefined; | |||
There was a problem hiding this comment.
Also here, the spec version looks more reasonable than the v8 version.
|
This is ready to merge. |
|
lgtm |
ngzhian
added a commit
to ngzhian/spec
that referenced
this pull request
Nov 16, 2021
rossberg
added a commit
that referenced
this pull request
Apr 21, 2024
Fix typing of `ref.i31` in the appendix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original version of this file was a fork of the V8 module builder. This is just an update with the additional functionality that we have seen fit to add in our tests, including, e.g., the new names section format.