Split files into given, spec and host dirs #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -51,7 +51,7 @@ def find_interpreter(path): | |||
| def rebuild_interpreter(path): | |||
| print("// building %s" % path) | |||
| sys.stdout.flush() | |||
| exitCode = subprocess.call(["ocamlbuild", "-libs", "bigarray, nums, str", "main.native"], cwd=os.path.abspath("src")) | |||
| exitCode = subprocess.call(["ocamlbuild", "-libs", "bigarray, nums, str", "-Is", "given, spec, host", "host/main.native"], cwd=os.path.abspath("src")) | |||
There was a problem hiding this comment.
ml-proto/README.md also has a copy of this build command; as long as it's still there, would you mind updating it too?
|
lgtm |
lukewagner
added a commit
that referenced
this pull request
Sep 8, 2015
Split files into given, spec and host dirs
littledan
pushed a commit
to littledan/spec
that referenced
this pull request
Mar 4, 2018
Fix links to WebAssembly stack and evaluation context.
eqrion
pushed a commit
to eqrion/wasm-spec
that referenced
this pull request
Jul 18, 2019
`memory.init`, `memory.copy`, `memory.fill`, `table.init`, and `table.copy` should all fail if their ranges are out-of-bounds, even if the count is zero, similar to for active segments. See the discussions here: WebAssembly/design#897, WebAssembly/bulk-memory-operations#11.
alexcrichton
pushed a commit
to alexcrichton/spec
that referenced
this pull request
Nov 18, 2019
dhil
pushed a commit
to dhil/webassembly-spec
that referenced
this pull request
Mar 2, 2023
rossberg
added a commit
that referenced
this pull request
Mar 7, 2024
Clarify order of the memory.copy immediates
rossberg
pushed a commit
that referenced
this pull request
Sep 4, 2024
Report status of SpiderMonkey implemention
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch splits the files into the three dirs as described in #47.