grow_memory takes page size #260
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
lgtm |
|
lgtm |
|
Merging, with lgtms and no objections. |
sunfishcode
added a commit
that referenced
this pull request
Mar 21, 2016
grow_memory takes page size
|
|
||
| (export "size_at_least" $size_at_least) | ||
| (func $size_at_least (param i32) (result i32) (i32.ge_u (memory_size) (get_local 0))) | ||
| (func $grow (param $sz i32) (result i32) (grow_memory (get_local $sz))) |
There was a problem hiding this comment.
AstSemantics says this should be a multiple of the page size, but this sends in values like 1 which are meant to be multiplied by it. Which is wrong?
There was a problem hiding this comment.
@kripken It looks like WebAssembly/design#598 has not been merged which updated AstSemantics. People seemed to support changing grow_memory to accept units of pages rather than bytes and there seems to be some support for also returning the new size in pages.
ngzhian
added a commit
to ngzhian/spec
that referenced
this pull request
Nov 4, 2021
Implement i16x8 operations
dhil
pushed a commit
to dhil/webassembly-spec
that referenced
this pull request
Mar 2, 2023
…h' (WebAssembly#260) * Adds validation algorithm case for `throw x`, adds missing x to 'catch' * Apply suggestions from code review Co-authored-by: Andreas Rossberg <rossberg@mpi-sws.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To go along with WebAssembly/design#598