Fix Echidna dry-run logic #1857
Conversation
| ${{ !((github.event_name == 'workflow_dispatch' && !inputs.dry-run) || | ||
| (github.event_name == 'push' && github.repository == 'WebAssembly/spec' && github.ref == 'refs/heads/main')) }} |
There was a problem hiding this comment.
I think this is slightly clearer if we distribute the ! a bit:
| ${{ !((github.event_name == 'workflow_dispatch' && !inputs.dry-run) || | |
| (github.event_name == 'push' && github.repository == 'WebAssembly/spec' && github.ref == 'refs/heads/main')) }} | |
| ${{ (github.event_name != 'workflow_dispatch' || inputs.dry-run) && | |
| !(github.event_name == 'push' && github.repository == 'WebAssembly/spec' && github.ref == 'refs/heads/main')) }} |
There was a problem hiding this comment.
Maybe. It's written like this because dry-run is already "inverted", and it was easier to think of it as "publish for real if these conditions are met". Another option is to actually reflect that in the variable name in this file, and then invert it when passing through to echidna's curl request as dry-run status. The downside of that is that we'd have to do the logic inversion of "true" to "false" in Makefile shell syntax, which seems worse than doing it in the GH script syntax here.
There was a problem hiding this comment.
I added a comment. If you still think this suggestion is better, I don't really mind switching it.
No description provided.