Tighter typing of Break #180
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good to me :) |
| @@ -24,7 +24,7 @@ | |||
| (loop $exit $cont | |||
| (set_local $i (i32.add (get_local $i) (i32.const 1))) | |||
| (if (i32.eq (get_local $i) (i32.const 5)) | |||
| (br $cont (i32.const -1)) | |||
| (br $cont) | |||
There was a problem hiding this comment.
Perhaps also add an assert_invalid test?
|
lgtm |
ngzhian
pushed a commit
to ngzhian/spec
that referenced
this pull request
Nov 4, 2021
…#180) Tests are synced from WAVM/WAVM#251
dhil
pushed a commit
to dhil/webassembly-spec
that referenced
this pull request
Mar 2, 2023
…ebAssembly#180) * Update core formal spec to the current (3rd) EH proposal As described in `proposals/exceptions/Exceptions.md` and in `proposals/exceptions/Exceptions-formal-overview.md`. * Detailed changes from the previous (2nd proposal) formal spec: - Removed: + the reference type "exnref" is removed, + the administrative instruction "REFEXNADDR" is removed, + Release dependencies "bulk instructions" and "reference types" are removed. - Renamed: + "exn" and (most occurrences of) "exception" renamed to "tag", + "EITYPE" renamed to "TAGITYPE", + "ETYPE" renamed to "TAGTYPE", + variable names for tags changed from "et" to "tt" or "tagt" and "iet" to "itagt", + "CATCHN" is renamed to "CATCHadm". + "THROWADDR" is renamed to "THROWadm". - Adjusted: + syntax and rules for "TRY-CATCH", "RETHROW", and "CATCHadm", + folded text format for "TRY-CATCH", + validation example of control frame with opcode catch. - Added: + validation example of control frame with opcode catch_all, + administrative instructions "CAUGHTadm" and "DELEGATEadm" with rules, + syntax and rules for "TRY-DELEGATE". - Most prose that is changing in the 3rd spec is removed and several temporary `..todo::` sections are added. + These will be updated in followup PRs. Co-authored-by: Heejin Ahn <aheejin@gmail.com> Co-authored-by: Andreas Rossberg <rossberg@mpi-sws.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Disallows redundant arguments to a break targeting a label of type
None(addresses #179).Conceptually, there is no specific harm in allowing this, but it also is not useful. Rather be consistent with the checking for calls.