test(binary.wast): adjust br_table length test to work with streaming validation #1715
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
current implementation fails on streaming validation due to interpreting 0x020x0b as block with type 11 which doesn't exist; so add enough types such that 0x0b resolves to a valid one, thereby passing validation and erroring at the expected state.
dhil
added a commit
to wasmfx/specfx
that referenced
this pull request
Jan 25, 2024
* [test] Adjust br_table length test to avoid wrong failure (WebAssembly#1715) * [spec] Fix extmul & extadd execution (WebAssembly#1716) * [interpreter] Add dune dependencies (WebAssembly#1717) * Revert "[interpreter] Add dune dependencies (WebAssembly#1717)" This reverts commit 44ed035. * [interpreter/test] Fix inconsistent use of float values in `spectest` (WebAssembly#1718) * [spec] Fix operand order in reduction of shape.replace_lane (WebAssembly#1721) * [spec] Fix sx to be sx? in reduction of vcvtop_zero (WebAssembly#1720) --------- Co-authored-by: Rod Vagg <rod@vagg.org> Co-authored-by: 702fbtngus <79245586+702fbtngus@users.noreply.github.com> Co-authored-by: Muqiu Han (韩暮秋) <muqiu-han@outlook.com> Co-authored-by: Andreas Rossberg <rossberg@mpi-sws.org> Co-authored-by: Dongjun Youn / 윤동준 <f52985@gmail.com> Co-authored-by: Hoseong Lee <101983402+HoseongLee@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current implementation fails on streaming validation due to interpreting
0x020x0bas block with type 11 which doesn't exist; so add enough types such that0x0bresolves to a valid one, thereby passing validation and erroring at the expected state.This was previously reported in #1355 but never fixed, and I've just discovered it for myself.
Suggestions for making this more realistic or safe welcome! I'm a bit concerned about adding so many duplicate types in here but I don't believe that's illegal according to spec. My first pass at this changed the first
0x0bto an0x00but that breaks the realism a bit too much since you need the 3 breaks and the wild0x00makes no sense. The test is trying to get at the br_table having a missing byte.