Fix an example code for ref.cast in MVP.md #527
Merged
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The first operand for `ref.cast` should be a reference type.
However, the code example in `MVP.md` seems to have a heaptype
which is invalid.
(Assuming the `$C` is defined as follows based on the context)
```
(module
(type $A (sub (struct)))
(type $B (sub $A (struct (field i32))))
(type $C (sub $B (struct (field i32 i32))))
(func $castBtoC (param $x (ref $B)) (result (ref $C))
(ref.cast $C (local.get $x))
)
)
```
```
$ wasm -d test.wat
test.wat:6.15-6.17: syntax error: unexpected token
```
(Where `wasm` is a reference interpreter built from
WebAssembly@0ba84fb)
rossberg
approved these changes
Feb 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first argument for
ref.castshould be a reference type. However, the code example inMVP.mdseems to have a heaptype.(Assuming the
$Cis defined as follows based on the context)(Where
wasmis a reference interpreter built from 0ba84fb)Please let me know if I misunderstand something :)