Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[spec] Fix spec for execution of struct.new, array.new_fixed and br_on_cast(_fail) #456

Merged
merged 2 commits into from
Oct 26, 2023

Conversation

f52985
Copy link
Contributor

@f52985 f52985 commented Oct 26, 2023

Hello,
This pull request fixes some minor errors in the specification for execution of struct.new, array.new_fixed and br_on_cast(_fail) instructions.

  1. Change the last Return ... in prose notation specification into Push ... to the stack for both new instructions.
  2. Change array ft^n in formal notation specification into array ft for array.new_fixed instruction.
  3. Add the frame F in the reduction rule of br_on_cast(_fail), as F is used in the auxiliary function clos.
  4. Fix typo: X{rt}_2 ~> \X{rt}_2for br_on_cast(_fail) instructions.

@f52985 f52985 changed the title [spec] Fix spec for execution of struct.new and array.new_fixed [spec] Fix spec for execution of struct.new, array.new_fixed and br_on_cast(_fail) Oct 26, 2023
Copy link
Member

@rossberg rossberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks!

@rossberg rossberg merged commit 409ea04 into WebAssembly:main Oct 26, 2023
4 checks passed
@f52985 f52985 deleted the gc branch November 3, 2023 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants