-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revive legacy JS API and restructure legacy spec directory #303
Conversation
- Renames `document/legacy/exceptions` to `document/legacy/exception-handling` to match the proposal name. - This adds `core` and `js-api` directory in `document/legacy/exception-handling`, moves all core spec files into `core/`, and restores the deleted legacy JS API files in `js-api/`. The core legacy spec only contains the EH instructions, which is easier to view, but it is hard to precisely carve out the modified part from the JS API file, so this adds the whole file for the legacy spec.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Personally, I'd prefer keeping it as just "exceptions" (since it's shorter and because it's not just the catch mechanism). But I'm fine either way.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, don't really have any opinion on the naming.
I'm not strongly opinionated on the directory name either. The main reason I renamed it was in case there will be other proposals part of which may end up in this |
Will revert back to |
Yeah, I sincerely hope this doesn't become a regular thing. :) FWIW, I don't think proposal names are highly relevant for later spec matters, since they are historic and sometimes become inaccurate when a proposal evolves, see e.g. "bulk memory ops", "threads", etc. |
WebAssembly#303 broke the core spec links. This fixes it by adding `core/` to the directory links and also adds the JS API spec link to the web page.
#303 broke the core spec links. This fixes it by adding `core/` to the directory links and also adds the JS API spec link to the web page.
This adds
core
andjs-api
directory indocument/legacy/exceptions
, moves all core spec files intocore/
, and restores the deleted legacy JS API files injs-api/
.The core legacy spec only contains the EH instructions, which is easier to view, but it is hard to precisely carve out the modified part from the JS API file, so this adds the whole file for the legacy spec.