[js-api] Add test for preserving identity in rethrow #253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds JS API tests that show `catch`-`rethrow` and `catch_all`-`rethrow` preserve exception objects' identity.
Ms2ger
approved these changes
Feb 16, 2023
|
LGTM! we should maybe also have a test for exporting a tag, and throwing an instance of that tag from JS, and catching it in wasm. Also this test doesn't check that the payload that propagates into wasm is the same one thrown by JS. |
|
@Ms2ger Thanks for the review! By the way can you let me merge my own PRs, so that I can possibly wait for others' comments and address them before merging? |
aheejin
added a commit
to aheejin/exception-handling
that referenced
this pull request
Feb 17, 2023
This makes some cosmetic changes to the identity-preserving `rethrow` test added in WebAssembly#253. This is to prepare for adding the same set of tests for a Wasm-defined-and-exported tag, as requrested in WebAssembly#253 (comment).
aheejin
added a commit
to aheejin/exception-handling
that referenced
this pull request
Feb 17, 2023
This makes some cosmetic changes to the identity-preserving `rethrow` test added in WebAssembly#253. This is to prepare for adding the same set of tests for a Wasm-defined-and-exported tag, as requrested in WebAssembly#253 (comment). This also contains a one-liner drive-by fix for a variable name in `wasm-module-builder.js`.
aheejin
added a commit
that referenced
this pull request
Feb 23, 2023
This makes some cosmetic changes to the identity-preserving `rethrow` test added in #253. This is to prepare for adding the same set of tests for a Wasm-defined-and-exported tag, as requrested in #253 (comment).
aheejin
added a commit
to aheejin/exception-handling
that referenced
this pull request
Feb 23, 2023
This addresses WebAssembly#253 (comment) by adding a set of tests that use a Wasm-defined and exported tag.
aheejin
added a commit
that referenced
this pull request
Feb 28, 2023
This addresses #253 (comment) by adding a set of tests that use a Wasm-defined and exported tag.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds JS API tests that show
catch-rethrowandcatch_all-rethrowpreserve exception objects' identity.Depends on #252.