Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tooling: JS+wasm dead code stripping #434

Merged
merged 2 commits into from
Oct 30, 2015
Merged

Tooling: JS+wasm dead code stripping #434

merged 2 commits into from
Oct 30, 2015

Conversation

jfbastien
Copy link
Member

As discussed in #230.

@lukewagner
Copy link
Member

Do you think there is something actionable within the design repo? There are a lot of interesting questions in the toolchain design space (design of .o files and static link libraries that incorporate JS); I wonder if a new repo containing docs describing the design of the toolchain (into which the new llvm-wasm backend fits) would make sense.

@lukewagner
Copy link
Member

Oh excuse me, I thought this was an issue, I didn't see it was a PR!

@lukewagner
Copy link
Member

lgtm

@@ -44,6 +44,12 @@ The tooling we expect to support includes:
- Instrumentation-based.
* Process dump: local variables, call stack, heap, global variables, list of
threads.
* JavaScript+WebAssembly size optimization tool. Some developers have huge
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, but all the other bullet points are a name + :. Perhaps change the first . to :? In which case, maybe also edit to remove the later : to avoid repetition.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point. I updated the sentence, and shortened it so it fits better with the surrounding.

@sunfishcode
Copy link
Member

lgtm

jfbastien added a commit that referenced this pull request Oct 30, 2015
Tooling: JS+wasm dead code stripping
@jfbastien jfbastien merged commit eecb3d8 into master Oct 30, 2015
@jfbastien jfbastien deleted the jfbastien-patch-1 branch October 30, 2015 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants