-
Notifications
You must be signed in to change notification settings - Fork 695
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Source maps applied to wasm binaries #1051
Open
dschuff
wants to merge
10
commits into
main
Choose a base branch
from
sourcemaps
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
ca1aea9
Add proposal for applying sourcemap spec to wasm
dschuff dbb3f06
move to Web.md
dschuff cc5a797
fix typo
dschuff 341f5a7
Clarify that SourceMap HTTP header only applies to response-based API…
dschuff 4bf5625
fix typo and use line 1 instead of 0
dschuff 741f989
s/wasm/WebAssembly
dschuff 8207bae
Remove source maps from FutureFeatures.md
dschuff ed75dfa
punctuation
dschuff 4a40b56
Merge remote-tracking branch 'origin/master' into sourcemaps
dschuff d02d42f
clarify source mapping URL resolution
dschuff File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just to understand the relative resolution with "page's origin", if
WebAssembly.instantiate()
was called from a page's script at "http://example.org/~user/page.html", and wasm'ssourceMappingURL
is specified as "maps/t.wasm.map", the resulting source map URL will be "http://example.org/maps/t.wasm.map", is it correct? Doesdocument.baseURI
affect this?