Tables and memories #668
Merged
Tables and memories #668
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kripken
force-pushed
the
tables_n_memories
branch
from
a4788e1
to
d23a53f
Compare
kripken
force-pushed
the
tables_n_memories
branch
from
21afe8c
to
086c4c0
Compare
|
Er... what's that about not modelling the |
|
See WebAssembly/design#736 and in particular WebAssembly/design#736 (comment) and WebAssembly/design#736 (comment) |
kripken
force-pushed
the
tables_n_memories
branch
from
f141afd
to
7851e3a
Compare
|
This is now good to go if anyone wants to review, I added table element offset support too. |
|
Sorry about that. I'm actually in the midst of a merge fest with rebasing the spec's |
|
Okay, everything is merged into the |
|
Thanks @rossberg-chromium. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For WebAssembly/spec#316
This is the best I can do for now, as we are skipping ahead to the
stackbranch (as I was convinced not to try to model thedroptype system changes), so this adds parsing and support but still runs the old spec tests, i.e., it should work on both old and new syntax, but is untested on the new (as those tests containdropetc.). I did have to temporarily disable one spec test.