New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Wasm GC] Skip types with subtypes in SignatureRefining #5544

Merged

kripken merged 1 commit into main from sig.sub.no

Mar 3, 2023

Member

kripken commented Mar 3, 2023

For now just skip them, to avoid problems. In the future we should look
into modifying their children, when possible.

Fixes #5463

fix

5c46b26

kripken requested a review from tlively

March 3, 2023 21:52

tlively approved these changes

View reviewed changes

kripken merged commit 069aec9 into main

kripken deleted the sig.sub.no branch

March 3, 2023 22:36

radekdoulik pushed a commit to dotnet/binaryen that referenced this pull request


          [Wasm GC] Skip types with subtypes in SignatureRefining (WebAssembly#…

f436371

…5544)

For now just skip them, to avoid problems. In the future we should look
into modifying their children, when possible.

Fixes WebAssembly#5463

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet