Allows parsing debug information in the .S files #544
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -36,4 +36,7 @@ | |||
| # define WASM_UNREACHABLE() abort() | |||
| #endif | |||
|
|
|||
| #define WASM_UNUSED(expr) \ | |||
There was a problem hiding this comment.
this wasn't obvious to me what it does, please add a comment
Currently it ignores this information. Also it allows parse files with -asm-verbose=true.
|
Added comment for the WASM_UNUSED macro, fixed debug.s tests output, and addressed size and auto type nits. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(Portion of #347)
The patch allows parsing of the debug information, but currently it ignores/skips it. This will allows parse files with -asm-verbose=true too.