Output inf/-inf rather than infinity/-infinity #1046
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wast2wasm wes recently updated to only support the former: WebAssembly/wabt#482
|
Why did wabt make this change? Is that what the wasm spec requires? |
|
I think so yes. @binji ? |
|
Yes, looks like this, along with a bunch of other changes landed here: WebAssembly/spec#471 in the spec. This change, along with one other change to allow alternative syntax for 'loop' signatures seems to enough to allow s2wasm output to be handled by wastwasm. |
|
Yes, previously |
|
Thanks, lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
wast2wasm was recently updated to only support the
former: WebAssembly/wabt#482