Refactor optimization opts #1023
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I believe this is something @jfbastien suggested a while ago. |
src/tools/optimization-options.h
Outdated
| namespace wasm { | ||
|
|
||
| struct OptimizationOptions : public Options { | ||
| const std::string DEFAULT_OPT_PASSES = "O"; |
There was a problem hiding this comment.
Hmm, that does sound like a good idea, but when I try it I get
in-class initialization of static data member ‘const string wasm::OptimizationOptions::DEFAULT_OPT_PASSES’ of non-literal type
call to non-constexpr function
I tried changing it to a const char* but it still complains about
error: ‘constexpr’ needed for in-class initialization of static data member ‘const char* wasm::OptimizationOptions::DEFAULT_OPT_PASSES’ of non-integral type
There was a problem hiding this comment.
This works:
static constexpr char DEFAULT_OPT_PASSES[] = "O";
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a nice class instead of hackish inline-c-include of a header.