-
Notifications
You must be signed in to change notification settings - Fork 757
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
What happened to binary releases? #4148
Comments
I don't think we changed anything intentionally, but yes, the new version 102 lacks binaries. Looks like builds failed: https://github.com/WebAssembly/binaryen/actions/runs/1222083042 I'm not very familiar with github actions so those errors don't immediately suggest anything to me... @sbc100 any ideas? |
Looks like the "upload-release-asset" step is failing for each of the builders. binaryen/.github/workflows/build_release.yml Lines 69 to 77 in 5b90e03
I have no clues yet as to why. |
Looks like a temporary failure to me. I would just retry it, at least once. |
Just noticed that another release was created today and the GHA failed for that one as well: https://github.com/WebAssembly/binaryen/actions/runs/1233610300. |
Indeed, looks like the upload recipe we were using has become unmaintained: #4151 |
Well I tried 3 different alternative github action and they all failed in different ways :( For now I guess we could download the aritfacts form the CI builder and then upload them manually to the release.. :( |
You can find the CI artifacts here: https://github.com/WebAssembly/binaryen/actions/runs/1222068571 Do those work for you? |
Not for us, as we are interested in the alpine-based build. I guess we'll switch to compiling our own version for both archs (Amd64 and Arm64). |
This is a toolkit often used when developing for WebAssembly. I've used version 101 (and not version 102, which is the latest version) because the latest version doesn't have any binaries. For details, see: WebAssembly/binaryen#4148
This is a toolkit often used when developing for WebAssembly. I've used version 101 (and not version 102, which is the latest version) because the latest version doesn't have any binaries. For details, see: WebAssembly/binaryen#4148
This is a toolkit often used when developing for WebAssembly. I've used version 101 (and not version 102, which is the latest version) because the latest version doesn't have any binaries. For details, see: WebAssembly/binaryen#4148
Is there any update on this? @sbc100 https://github.com/softprops/action-gh-release seems to be well maintained and supports uploading assets, so maybe it's possible to switch to that GHA? |
Looks like it works! |
Hey that's great! Would this be a good opportunity for another release? 🙃 |
It seems that the action we were using is not longer working: https://github.com/actions/upload-release-asset See WebAssembly/binaryen#4148
It seems that the action we were using is not longer working: https://github.com/actions/upload-release-asset See WebAssembly/binaryen#4148
It seems that the action we were using is not longer working: https://github.com/actions/upload-release-asset See WebAssembly/binaryen#4148
It seems that the action we were using is not longer working: https://github.com/actions/upload-release-asset See WebAssembly/binaryen#4148
Looks like version 111 is also missing binary assets. It doesn't look like a workflow was even kicked off for it: https://github.com/WebAssembly/binaryen/actions/workflows/create_release.yml |
I think maybe you have to push the tag.. not create it directly in the UI. Can you try deleting the tag and pushing it from your local checkout? |
I did create the tag locally and push it up. I only used the UI to create the release from that tag. |
I recreated the |
In the past you had always attached the binary build for various platforms to a release. What's the reason for stopping in the latest release?
This impacts us, since we used these binary releases in our CI setup. I only noticed that they no longer exist since our CI broke.
Moreover, we often recommended installing the binary release directly in our community. A number of
stable
Linux distributions still contain ancientbinaryen
releases, so this was an easy way to get the latest release for e.g. Ubuntu LTS (IIRC).Yeah, so would be great if you could add them back :-).
The text was updated successfully, but these errors were encountered: