Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/loader #954

Merged
merged 56 commits into from
Dec 6, 2022
Merged

Feat/loader #954

merged 56 commits into from
Dec 6, 2022

Conversation

rinzler99
Copy link
Contributor

@chaitanyapotti chaitanyapotti self-requested a review November 29, 2022 03:07
@chaitanyapotti chaitanyapotti mentioned this pull request Nov 29, 2022
@lionellbriones lionellbriones self-requested a review November 29, 2022 08:04
@chaitanyapotti chaitanyapotti mentioned this pull request Dec 6, 2022
@himanshuchawla009
Copy link
Member

Screenshot_20221206_193358

scrollbar showing up on clicking view more @lionellbriones

@himanshuchawla009
Copy link
Member

himanshuchawla009 commented Dec 6, 2022

not able to use appLogo any more on login modal header, I used following code snippet:-

 new Web3Auth({
          chainConfig: ethChainConfig,
          clientId: config.clientId[this.openloginNetwork],
          authMode: "DAPP",
          enableLogging: true,
          uiConfig: {
            theme: "light",
            appLogo: "https://avatars.githubusercontent.com/u/72950769?s=200&v=4",
          },
        });
        ```

@himanshuchawla009
Copy link
Member

image

i think app logo should be with round borders as well. @lionellbriones

@chaitanyapotti
Copy link
Member

Scroll only happens on view more if the screen height is less than 620px.. this is expected behaviour

@chaitanyapotti
Copy link
Member

chaitanyapotti commented Dec 6, 2022

appLogo will be shown along with whitelabel on modal header in next release

@himanshuchawla009
Copy link
Member

Scroll only happens on view more if the screen height is less than 620px.. this is expected behaviour

ok

Copy link
Member

@chaitanyapotti chaitanyapotti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Member

@himanshuchawla009 himanshuchawla009 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@chaitanyapotti chaitanyapotti merged commit a71a7ca into master Dec 6, 2022
@chaitanyapotti chaitanyapotti deleted the feat/loader branch December 6, 2022 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants