Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Image fix, height fix #1951

Merged
merged 2 commits into from
Sep 19, 2024
Merged

Image fix, height fix #1951

merged 2 commits into from
Sep 19, 2024

Conversation

smgv
Copy link
Contributor

@smgv smgv commented Sep 19, 2024 •
edited
Loading

Motivation and Context

Jira Link: https://toruslabs.atlassian.net/browse/PD-3839

Description

  • Changes logos for IOS and Android
  • handled dark and light logos for Image component
  • fixed height for adapter container
  • change ui for vue-demo-app

How has this been tested?

Screenshots (if appropriate):

https://github.com/user-attachments/assets/b842dab9-2ed3-4ab1-9e95-d892c5c39029
https://github.com/user-attachments/assets/407194fc-bbca-4e86-b3ed-80b2dfb3b72c
https://github.com/user-attachments/assets/373562fb-bd21-4a9d-ad41-98e751cb1aee

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project. (run lint)
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@smgv smgv requested a review from chaitanyapotti September 19, 2024 07:08
chaitanyapotti
chaitanyapotti approved these changes Sep 19, 2024
View reviewed changes
Copy link
Member

@chaitanyapotti chaitanyapotti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@chaitanyapotti chaitanyapotti merged commit b6862b3 into master Sep 19, 2024
3 checks passed
@chaitanyapotti chaitanyapotti deleted the feat/ux-review-changes branch September 19, 2024 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chaitanyapotti chaitanyapotti chaitanyapotti approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@smgv @chaitanyapotti