Feat/remove ethereumjs #1921
Merged
Feat/remove ethereumjs #1921
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -156,7 +142,7 @@ export class TransactionFormatter { | |||
| clonedTxParams.gasPrice = defaultGasPrice as never; | |||
| } | |||
|
|
|||
| clonedTxParams.type = this.isEIP1559Compatible ? TRANSACTION_ENVELOPE_TYPES.FEE_MARKET : TRANSACTION_ENVELOPE_TYPES.LEGACY; | |||
| clonedTxParams.type = Number(this.isEIP1559Compatible ? TRANSACTION_ENVELOPE_TYPES.FEE_MARKET : TRANSACTION_ENVELOPE_TYPES.LEGACY); | |||
There was a problem hiding this comment.
just make this Number.parseInt(x,16) to remove ambiguity
| const unsignedEthTx = TransactionFactory.fromTxData(finalTxParams, { | ||
| common, | ||
| }); | ||
| const ethTx = Transaction.from(finalTxParams); |
There was a problem hiding this comment.
might want to remove from from finalTxParams
...viders/ethereum-provider/src/providers/privateKeyProviders/TransactionFormatter/formatter.ts
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Remove ethereumjs/tx and /common
Jira Link:
Description
Replace ethereumjs/tx and /common with ethers to reduce package size
How has this been tested?
tested with demo app
Screenshots (if appropriate):
Types of changes
Checklist: