feat: cognito working example #184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
himanshuchawla009
requested changes
May 17, 2022
| @@ -0,0 +1,23 @@ | |||
| const webpack = require("webpack"); | |||
|
|
||
| - Now your google login provider is configured, you can enable it in your App client settings in aws console. | ||
|
|
||
| - Now go to your hosted app domain , it should show you hosted ui with google login button. |
There was a problem hiding this comment.
implementation is different from readme, we are not using cognito hosted UI right, we are using custom ui. Please update the steps in readme accordingly.
There was a problem hiding this comment.
we are using hosted UI for aws cognito not for web3auth, i think this is right.
There was a problem hiding this comment.
can you add the screenshot of hosted ui.
| name: "Custom cognito Login", | ||
| verifier: "cognito-demo", | ||
| typeOfLogin: "jwt", | ||
| clientId: "29343gi24opt30vsa5s7u8gfvg", |
There was a problem hiding this comment.
add code comment here about client id.
| extraLoginOptions: { | ||
| domain: "https://web3auth.auth.us-west-2.amazoncognito.com/oauth2", | ||
| verifierIdField: "email", | ||
| response_type: "token", |
There was a problem hiding this comment.
add code comment about each variable here.
|
there is some flicker while login, don't show logged in view on clicking of login button as shown in video, fix it plz @rinzler99 Screen.Recording.2022-05-17.at.2.56.36.PM.mov |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.