Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add default ui mode for No Modal SDK #1827

Merged
merged 1 commit into from
May 17, 2024
Merged

Conversation

yashovardhan
Copy link
Member

For consistency between no modal and modal ui configs, adding in the default mode within the no modal sdk as light mode.

@BboyStatix
Copy link
Contributor

What about Openlogin SDK @chaitanyapotti

Copy link
Member

@chaitanyapotti chaitanyapotti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@chaitanyapotti
Copy link
Member

No need of default for openlogin sdk

@chaitanyapotti chaitanyapotti merged commit d9edd2d into master May 17, 2024
2 checks passed
@chaitanyapotti chaitanyapotti deleted the add-light-mode-no-modal branch May 17, 2024 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants