Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make plugin work with sfa too #1826

Merged
merged 4 commits into from
May 20, 2024
Merged

Make plugin work with sfa too #1826

merged 4 commits into from
May 20, 2024

Conversation

chaitanyapotti
Copy link
Member


name: Bug fix PR
about: Create a report
title: ""
labels: ""
assignees: ""

Descriptionf

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes # (issue) (Link github issue)
(Add jira ticket link)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (fix that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Screenshots

Please add screenshots if applicable

Test Configuration:

Frontend

Device 1

  • Device: [e.g. iPhone6]
  • OS: [e.g. iOS]
  • Browser [e.g. chrome, safari]
  • Version [e.g. 22]

Device 2

  • Device: [e.g. iPhone6]
  • OS: [e.g. iOS]
  • Browser [e.g. chrome, safari]
  • Version [e.g. 22]

or

Backend

Include postman test suite url or steps to run test cases

Checklist

  • My code follows the style guidelines of this project.
  • I've run lint and build scripts
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove that my feature works
  • New and existing unit tests pass locally with my changes

Copy link
Contributor

@arch1995 arch1995 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@chaitanyapotti chaitanyapotti merged commit 65b269d into master May 20, 2024
2 checks passed
@chaitanyapotti chaitanyapotti deleted the feat/plugin-refactor branch May 20, 2024 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants