Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize whitelist config #1789

Merged
merged 1 commit into from
Apr 16, 2024
Merged

optimize whitelist config #1789

merged 1 commit into from
Apr 16, 2024

Conversation

chaitanyapotti
Copy link
Member


name: Feature PR
about: Create a report
title: ""
labels: ""
assignees: ""

Description

Please include a summary of the change. Please also include relevant motivation and context. List any dependencies that are required for this change.

(Add jira ticket link)

Type of change

  • New feature (non-breaking change which adds functionality)
  • Breaking change (feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

If possible, include the google doc for testing sheet

  • Test A
  • Test B

Test Configuration:

Frontend

Device 1

  • Device: [e.g. iPhone6]
  • OS: [e.g. iOS]
  • Browser [e.g. chrome, safari]
  • Version [e.g. 22]

Device 2

  • Device: [e.g. iPhone6]
  • OS: [e.g. iOS]
  • Browser [e.g. chrome, safari]
  • Version [e.g. 22]

or

Backend

Include postman test suite url or steps to run test cases

Checklist:

  • My code follows the style guidelines of this project
  • I've run lint and build scripts
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Copy link
Contributor

@arch1995 arch1995 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@chaitanyapotti chaitanyapotti merged commit 35bd1c4 into master Apr 16, 2024
2 checks passed
@chaitanyapotti chaitanyapotti deleted the feat/whitelist-optim branch April 16, 2024 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants