Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix switch chain #1741

Merged
merged 3 commits into from
Feb 23, 2024
Merged

fix switch chain #1741

merged 3 commits into from
Feb 23, 2024

Conversation

lionellbriones
Copy link
Contributor

@lionellbriones lionellbriones commented Feb 23, 2024

Motivation and Context

Jira Link: https://toruslabs.atlassian.net/browse/PD-3882

Description

Save current chain on demo app to persist chain on reload
Catch error on Adding + Switch chain flow

How has this been tested?

Tested demo app by switching chain and refreshing page to see if the same chain is loaded on window reload.

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project. (run lint)
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Copy link
Contributor

@arch1995 arch1995 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@arch1995 arch1995 merged commit 79a453a into master Feb 23, 2024
2 checks passed
@arch1995 arch1995 deleted the fix/switch-chain branch February 23, 2024 11:38
@BboyStatix BboyStatix assigned BboyStatix and unassigned BboyStatix Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants