Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds plugin events #1739

Merged
merged 5 commits into from
Feb 23, 2024
Merged

Adds plugin events #1739

merged 5 commits into from
Feb 23, 2024

Conversation

arch1995
Copy link
Contributor

@arch1995 arch1995 commented Feb 22, 2024 •
edited
Loading

Motivation and Context

This PR aims to add support for emitting events from the plugins as well.

Jira Link:

Description

  • Adds plugin events as a interface from the base package.
  • Emit events from all the plugins i.e solana, and wallet services.

How has this been tested?

Developer and Devrels testes this manually.

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project. (run lint)
  • [x ] My change requires a change to the documentation.
  • [ x] I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

lionellbriones
lionellbriones approved these changes Feb 23, 2024
View reviewed changes
Copy link
Contributor

@lionellbriones lionellbriones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@arch1995 arch1995 merged commit 466b57a into master Feb 23, 2024
2 checks passed
@arch1995 arch1995 deleted the feat/plugin-events branch February 23, 2024 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yashovardhan yashovardhan yashovardhan approved these changes

@lionellbriones lionellbriones lionellbriones approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@arch1995 @lionellbriones @yashovardhan