Fix react demo app private key provider instantiated without chainNamespace in chainConfig #1716
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BboyStatix
commented
Feb 8, 2024
| @@ -109,25 +109,20 @@ export const Web3AuthProvider: FunctionComponent<IWeb3AuthState> = ({ children, | |||
| try { | |||
| const currentChainConfig = CHAIN_CONFIG[chain]; | |||
| let privateKeyProvider; | |||
| if (currentChainConfig.displayName === "Solana") { | |||
| if (currentChainConfig.chainNamespace === CHAIN_NAMESPACES.SOLANA) { | |||
| privateKeyProvider = new SolanaPrivateKeyProvider({ config: { chainConfig: currentChainConfig } }); | |||
There was a problem hiding this comment.
priv key provider was being instantiated by chain config object in chainConfig.ts which did not have chainNamespace key resulting in error.
BboyStatix
force-pushed
the
fix/demo-app
branch
2 times, most recently
from
5c6e190 to
bc3c2e0
Compare
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket Link
https://toruslabs.atlassian.net/browse/PD-3367