Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Turkish lang code #1692

Merged
merged 2 commits into from
Jan 22, 2024
Merged

Fix Turkish lang code #1692

merged 2 commits into from
Jan 22, 2024

Conversation

shahbaz17
Copy link
Member

@shahbaz17 shahbaz17 commented Jan 22, 2024 •
edited by BboyStatix
Loading

Motivation and Context

  • Add support for Turkish Language

Jira Link:
https://toruslabs.atlassian.net/browse/PD-3879?atlOrigin=eyJpIjoiNWE4ZWNlNzRiYzhiNGU1Y2E1YzQ0NTk3NWU3ZjkwYTUiLCJwIjoiaiJ9

Description

How has this been tested?

Manual Testing

  • Check if locales are loading correctly

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project. (run lint)
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@shahbaz17
Copy link
Member Author

Waiting for Web3Auth/Auth#287 to merge and release before updating the openlogin-utils dependency.

@shahbaz17 shahbaz17 marked this pull request as draft January 22, 2024 05:08
@shahbaz17 shahbaz17 marked this pull request as ready for review January 22, 2024 07:46
chaitanyapotti
chaitanyapotti approved these changes Jan 22, 2024
View reviewed changes
Copy link
Member

@chaitanyapotti chaitanyapotti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@chaitanyapotti chaitanyapotti merged commit 49ff091 into master Jan 22, 2024
2 checks passed
@chaitanyapotti chaitanyapotti deleted the fix-tk-to-tr branch January 22, 2024 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chaitanyapotti chaitanyapotti chaitanyapotti approved these changes

@arch1995 arch1995 Awaiting requested review from arch1995

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shahbaz17 @chaitanyapotti