Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/ci and test timeout fix #74

Merged
merged 2 commits into from
Nov 25, 2024
Merged

Fix/ci and test timeout fix #74

merged 2 commits into from
Nov 25, 2024

Conversation

hieu-w
Copy link
Contributor

@hieu-w hieu-w commented Nov 25, 2024 •
edited
Loading

Motivation and Context

Jira Link:
NA

Description

This PR fix CI failed due to example folder refactor to "examples" but not updated in s3 sync step.

How has this been tested?

CI work properly when going through all steps.

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project. (run lint)
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • My code requires a db migration.

@hieu-w
Update vitest.config.mjs
8732a0d 
Increase test timeout to 10 seconds
@hieu-w
Fix CI
23e4f58
chaitanyapotti
chaitanyapotti approved these changes Nov 25, 2024
View reviewed changes
Copy link
Member

@chaitanyapotti chaitanyapotti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@chaitanyapotti chaitanyapotti merged commit 6348479 into master Nov 25, 2024
3 checks passed
@chaitanyapotti chaitanyapotti deleted the fix/CI-and-test-timeout-fix branch November 25, 2024 05:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chaitanyapotti chaitanyapotti chaitanyapotti approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hieu-w @chaitanyapotti