-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update dependencies #30
base: feat/signer
Are you sure you want to change the base?
Conversation
95e416b
to
08d54ce
Compare
8649fc4
to
6fbf281
Compare
@AyushBherwani1998 Why are you replacing SFA with FND? There's a typealias already for what you're trying to change |
It was originally using the FND, but the FND network type is not compatible with loginWithJWT(SFA), but later realized FND is also required for node details. It'll require explicit conversion in loginWithJWT |
It is the same type due to the typealias. See here: https://github.com/Web3Auth/single-factor-auth-swift/blob/d9a8fd7885e37e74e61010f8fb240cbbafd1e577/Sources/SingleFactorAuth/SingleFactorAuthArgs.swift#L3 |
Please revert it. |
The force push already reverts it, and no the type alias is not work. Xcode
gives compilation error for the demo.
…On Sun, Sep 15, 2024 at 18:53 metalurgical ***@***.***> wrote:
Please revert it.
—
Reply to this email directly, view it on GitHub
<#30 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AIFWKA35M2YXT7ZEH43IPLDZWWC6PAVCNFSM6AAAAABLWD24QSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGNJRGU4TCOBRGY>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Link to where you're running into the problem? |
You can try the examples here: https://github.com/Web3Auth/web3auth-core-kit-examples/tree/main/mpc-core-kit-ios. Also, we shouldn't do this. This was done to make a better developer experience, and having the same enum across all platform SDKs. Web3Auth/single-factor-auth-swift@e9ae8be Maybe we can have a call tomorrow to discuss this change? cc:// @shahbaz17 |
893ae23
to
4e92f26
Compare
The quick start compiles, see here: |
002a03d
to
7f8f4b0
Compare
919783e
to
8aa87ae
Compare
Use commitChanges everywhere instead of syncLocalTransitions |
No description provided.