Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update dependencies #30

Open
wants to merge 38 commits into
base: feat/signer
Choose a base branch
from
Open

update dependencies #30

wants to merge 38 commits into from

Conversation

metalurgical
Copy link
Contributor

No description provided.

@metalurgical
Copy link
Contributor Author

metalurgical commented Sep 15, 2024

@AyushBherwani1998 Why are you replacing SFA with FND? There's a typealias already for what you're trying to change

@AyushBherwani1998
Copy link
Member

It was originally using the FND, but the FND network type is not compatible with loginWithJWT(SFA), but later realized FND is also required for node details. It'll require explicit conversion in loginWithJWT

@metalurgical
Copy link
Contributor Author

metalurgical commented Sep 15, 2024

@metalurgical
Copy link
Contributor Author

Please revert it.

@AyushBherwani1998
Copy link
Member

AyushBherwani1998 commented Sep 15, 2024 via email

@metalurgical
Copy link
Contributor Author

Link to where you're running into the problem?

@AyushBherwani1998
Copy link
Member

You can try the examples here: https://github.com/Web3Auth/web3auth-core-kit-examples/tree/main/mpc-core-kit-ios.

Also, we shouldn't do this. This was done to make a better developer experience, and having the same enum across all platform SDKs. Web3Auth/single-factor-auth-swift@e9ae8be

Maybe we can have a call tomorrow to discuss this change? cc:// @shahbaz17

@metalurgical
Copy link
Contributor Author

The quick start compiles, see here:
Web3Auth/web3auth-core-kit-examples@c32ce00

@metalurgical
Copy link
Contributor Author

Closes #29
Closes #28
Closes #27
Closes #31

@metalurgical metalurgical marked this pull request as ready for review November 25, 2024 07:40
Sources/mpc-core-kit-swift/Interface.swift Outdated Show resolved Hide resolved
Sources/mpc-core-kit-swift/MpcCoreKitSwift.swift Outdated Show resolved Hide resolved
Sources/mpc-core-kit-swift/MpcCoreKitSwift.swift Outdated Show resolved Hide resolved
Sources/mpc-core-kit-swift/MpcCoreKitSwift.swift Outdated Show resolved Hide resolved
Sources/mpc-core-kit-swift/MpcCoreKitSwift.swift Outdated Show resolved Hide resolved
@himanshuchawla009
Copy link
Member

Use commitChanges everywhere instead of syncLocalTransitions

Package.swift Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants