Fixes #13
Merged
Fixes #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes couple of issues regarding EnableMFA
Issue: #11
The issue was because of a couple of reasons. First, we did not check the device factor, if hashed key was not found. Upon enable MFA hashed key is deleted, so we should check the device factor. Second, there was a type issue while retrieving the data from
ILocalStorage. We were usingCodablebut default types of Swift are not Codable. UsedAnyinstead ofCodable.Issue: #12
We were not adding the
deviceMetadataShareIndexfor new users, which is used to backup share inenableMFA.Issue: #8
Rename the
loginfunction to keep it align with mpc-core-kit-web