Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

window.closed fixes #242

Merged
merged 1 commit into from
Jul 26, 2023
Merged

window.closed fixes #242

merged 1 commit into from
Jul 26, 2023

Conversation

chaitanyapotti
Copy link
Member

@chaitanyapotti chaitanyapotti commented Jul 26, 2023

optimistically wait for fb and line logins to finish in mobile browsers because window.closed isn't reliable in browsers with cross-origin-opener-policy set

@chaitanyapotti chaitanyapotti changed the title wait for fb and line logins to finish in mobile browsers because wind… window.closed fixes Jul 26, 2023
Copy link
Contributor

@arch1995 arch1995 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@chaitanyapotti chaitanyapotti merged commit 2b36d15 into master Jul 26, 2023
1 check passed
@chaitanyapotti chaitanyapotti deleted the feat/popup-timeout branch July 26, 2023 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants