Fix templates for all regionTypes #661
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
=> use correct field for color => for aura and totem, use yellow color instead of glow for all regionTypes except "icon" => model : no conditions Rename isUsableBlue => isNotUsableBlue
|
So we have |
InfusOnWoW
reviewed
Aug 22, 2018
| @@ -255,7 +402,7 @@ local function createAbilityAndDebuffTrigger(triggers, item) | |||
| createAbilityTrigger(triggers, 1, item, "showAlways"); | |||
| end | |||
|
|
|||
| local function subTypesFor(item) | |||
| local function subTypesFor(item, regionType) | |||
There was a problem hiding this comment.
This function should filter which options are available, so that for models only basic ones are offered. Offering some choices which don't actually work is not great.
| local function buffGreyed(conditions, trigger) | ||
| tinsert(conditions, buildCondition(trigger, checks.buffedFalse, {changes.grey})); | ||
| local function missingBuffGreyed(conditions, trigger, regionType) | ||
| if regionType ~= "model" then |
There was a problem hiding this comment.
There is the possibility of adding region types via plugins, and in fact there's a plugin: StopMotion
So any check for regionTypes needs to test the supported ones. Testing for not model does not work.
See the later comment on where to move the check though.
There was a problem hiding this comment.
done in #664
To check if the property exists for the regionType i did this:
WeakAuras.regionTypes[regionType].default[property]
I'm not 100% sure this is the right way to test it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
=> use correct field for color
=> for aura and totem, use yellow color instead of glow for all regionTypes except "icon"
=> model : no conditions
Rename isUsableBlue => isNotUsableBlue
#660