Let Masque Skin the Glow #645
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allows Masque to handle the Glow which inludes a custom glow for Circular Icons.
emptyrivers
requested changes
Aug 13, 2018
WeakAuras/RegionTypes/Icon.lua
Outdated
| end | ||
| WeakAuras.ShowOverlayGlow(region.__WAGlowFrame); | ||
| if MSQ then | ||
| if (showGlow) then |
There was a problem hiding this comment.
Your indentation needs work. 2 spaces is the format we use
WeakAuras/RegionTypes/Icon.lua
Outdated
| else | ||
| WeakAuras.HideOverlayGlow(region.button); | ||
| end | ||
|
|
|
Hey there, thanks for the contribution! I just fixed your indentation and merged it! |
|
that works too |
|
Yeah sorry about that. I'm not a programmer but followed the wiki as best I could. Set up vs-studio with the extensions mentioned so thought it was a good sign I didn't trigger any warnings :). Thanks for fixing it! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows Masque to handle the Glow which inludes a custom glow for Circular Icons.