Add group unit options #578
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stanzilla
added
⏱ Awaiting Review
|
This is a little under-cooked still actually |
Stanzilla
added
👩🔬 Work in Progress
|
Okay, done much more testing on this now and fixed the issue. |
emptyrivers
approved these changes
Aug 2, 2018
Stanzilla
requested changes
Aug 3, 2018
WeakAuras/BuffTrigger.lua
Outdated
| @@ -688,7 +697,7 @@ function WeakAuras.ScanAuras(unit) | |||
| -- Query count from aura cache | |||
| local aura_count, max = aura_object:GetNumber(id, triggernum, data), aura_object:GetMaxNumber(); | |||
| local satisfies_count = data.group_count(aura_count, max); | |||
|
|
|||
WeakAuras/Types.lua
Outdated
| @@ -1302,6 +1302,13 @@ WeakAuras.group_aura_stack_info_types = { | |||
| stack = L["Aura Stack"] | |||
| } | |||
|
|
|||
| WeakAuras.group_roles = { | |||
There was a problem hiding this comment.
we already have role_types, can we re-use and maybe add "any" to it?
There was a problem hiding this comment.
I thought about that but we don't actually want it to show "any" in the load conditions.
WeakAurasOptions/BuffTrigger.lua
Outdated
| @@ -756,6 +756,20 @@ function WeakAuras.GetBuffTriggerOptions(data, trigger) | |||
| end, | |||
| values = group_aura_stack_info_types | |||
| }, | |||
| ignoreSelf = { | |||
| type = "toggle", | |||
| name = "Ignore player", | |||
WeakAurasOptions/BuffTrigger.lua
Outdated
| }, | ||
| group_role = { | ||
| type = "select", | ||
| name = "Group Member Role", |
Stanzilla
approved these changes
Aug 4, 2018
emptyrivers
added
✔️ Ready to Merge
Also fix IgnoreSelf interaction with Group Member Count
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal is to provide options in the group=unit settings for users to specify raiding roles to watch and also exclude themselves from results.
The use case I had in mind for this was be to track "tank swap" debuffs on other tanks. These settings would let users only see debuffs on other tanks which is a very common thing to want to see without a very satisfactory method currently.
Currently while raiding as tank I would always focus my cotank and use the focus unit for tank monitoring Auras. This gets messy when there are 3 tanks and removes any other uses I might have for my focus. Other people have made complex TSU auras to track the other tank.
Of course I expect that the setting could be useful for other stuff too.