Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor of ModelPaths update script #4990

Merged
merged 3 commits into from
Apr 7, 2024
Merged

Refactor of ModelPaths update script #4990

merged 3 commits into from
Apr 7, 2024

Conversation

Stanzilla
Copy link
Contributor

@Stanzilla Stanzilla commented Apr 3, 2024

Description

Rewrites the ModelPath script to pull from wago.tools instead of wow.tools.

Since we are caching on the build config hash and the community is still naming stuff after builds get released, new m2 files might get added even though there's not been a build, these will be picked up on the next run, which I think is fine.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

@Stanzilla Stanzilla force-pushed the stanzilla/model-paths branch from f1b30bb to 553c2b7 Compare April 3, 2024 15:43
@Stanzilla Stanzilla force-pushed the stanzilla/model-paths branch from 553c2b7 to fa8c51e Compare April 3, 2024 17:33
@Stanzilla Stanzilla requested a review from mrbuds April 3, 2024 17:34
@Stanzilla Stanzilla force-pushed the stanzilla/model-paths branch from ecb75a9 to 3e738c3 Compare April 3, 2024 19:32
Copy link
Contributor

@InfusOnWoW InfusOnWoW left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did no test run, but the code changes do look okay. The atlas update runs once per week, which I think is better than once per day.

@Stanzilla Stanzilla merged commit 54d4190 into main Apr 7, 2024
1 check passed
@Stanzilla Stanzilla deleted the stanzilla/model-paths branch April 7, 2024 23:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants