Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI+++ #4592

Merged
merged 2 commits into from
Sep 17, 2023
Merged

UI+++ #4592

merged 2 commits into from
Sep 17, 2023

Conversation

mrbuds
Copy link
Contributor

@mrbuds mrbuds commented Sep 9, 2023

right now, only last commit is new compared to ui++ branch

@InfusOnWoW
Copy link
Contributor

I looked into how we are creating the fake states for options and whether we can find some generic way to do that.
But wasn't really convinced of any of my ideas on how that should look like.

I move your code a bit around so that RunTriggerFunc doesn't need to know about fake states, and while at it noticed that one of the fake state related things in RunTriggerFunc can be moved out of it.

@InfusOnWoW InfusOnWoW merged commit 43b78a1 into WeakAuras:main Sep 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants