Bossmod Timer fix

[mrbuds]

fix #4583

[InfusOnWoW]

Because RecheckTimers can run at any time (due to it being triggered also by boss mod events), and RecheckTimers needs to know whether to keep a bar alive or not, I think we need to write scheduledScanExpiresAt regardless of any triggerRemainingCheck, and this check should be extendTimer > 0.

So this code should probably use extendTimer > 0, and we also need to move it out of the remainingTime check and it needs to be duplicated in the else branch ~7 lines below.

[InfusOnWoW]

1. For the nextExpire we should also take scheduleScanExpire into account, that is I think we should add:

if self.nextExpire == nil then
     self.nextExpire = bar.scheduledScanExpireAt
elseif bar.scheduledScanExpireAt and bar.scheduledScanExpireAt > GetTime() and bar.scheduledScanExpireAt< self.nextExpire
    self.nextExpire= self.scheduledScanExpireAt
end

So that, at scheduledScanExpireAt the bar is actually removed.

2. For extended timers, we end up sending a TimerStop event everytime RecheckTimers is called. That doesn't sound too bad, though it's bit unfortunate.

3. Another point to consider is that this changes GetTimer/GetAllTimers beahviour in that they can and will now return expired bars (if they are kept alive via an extension). Looking at the code I think some callers of that need adjustment to not consider expired timers. In general GetTimer/GetAllTimers returning expired bars is correct, in so far as we explictly want to keep them around. But we need to add checks for auras that aren't responsible for the extension.

That is consider two auras:
Aura a: Shows 'foo', extends timers by 5s
Aura b: Shows all bars, no extension.

Then if a bar 'foo' expires (for which aura a matches), the bar is kept alive via the scheduledScanExpireAt code.

If in those 5s a DBM_TimerUpdate is fired for an unrelated timer, e.g. bar 'baz'
Then for Aura b, that will result in WeakAuras.ScanEvents('BossMod_TimerUpdate'), then the code (in useClone) will use:

• TimerMatchesGeneric, which doesn't care that the bar is expired
• copyAndSchedule, which again doesn't check that remainingTime is negative, to
• CopyBarToState, which doesn't check either.

So Aura b shows a dead timer.

[mrbuds]

can't bar.scheduledScanExpireAt be nil here?

[InfusOnWoW]

No if it is nil (or <= GetTime()) we would be in line 130

[mrbuds]

indeed sorry

your changes are good, i did only tests with auto-clone and didn't think enough about nextExpire